Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support numbers in Join type #258

Merged
merged 6 commits into from Sep 10, 2021
Merged

Conversation

o-alexandrov
Copy link
Contributor

Thank you for the Join type, really helpful.
Let's please support number parameters as well, so we could create results like the one below:

  • foo.0.bar

On a side note, I'm using Join type to cast type override on Array.join() and this native JavaScript function supports number parameters, which leads to believe this Join type should support it too.

@o-alexandrov
Copy link
Contributor Author

@avaly hello, sorry for the ping, you might want to comment on it, since Join type is your addition

@sindresorhus
Copy link
Owner

Can you update the doc comment to indicate that it accepts numbers too?

@o-alexandrov
Copy link
Contributor Author

@sindresorhus thank you for taking time and I apologize for forgetting to update some of the related docs.
in the last commit above, I carefully reviewed missed docs comments and updated them.

source/join.d.ts Outdated Show resolved Hide resolved
source/join.d.ts Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Update Join type: Adds support for "number" Support numbers in Join type Sep 10, 2021
@sindresorhus sindresorhus merged commit a001611 into sindresorhus:main Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants