Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Float type #330

Merged
merged 2 commits into from Dec 1, 2021
Merged

Add Float type #330

merged 2 commits into from Dec 1, 2021

Conversation

jonahsnider
Copy link
Contributor

@jonahsnider jonahsnider commented Nov 30, 2021 •
edited

Adds a Float and NegativeFloat type.
Not really sure what the use case for NegativeFloat would be though.

Also: Should these be called NonInteger instead of Float? Might be a more accurate description of what the type is, especially considering JS numbers are always float64s.

Fixes #329

@sindresorhus sindresorhus merged commit 7770489 into sindresorhus:main Dec 1, 2021
@sindresorhus
Copy link
Owner

Also: Should these be called NonInteger instead of Float? Might be a more accurate description of what the type is, especially considering JS numbers are always float64s.

Nah, I think Float is fine.

@sindresorhus
Copy link
Owner

If you have time and interest, I could use some help with reviewing the open pull requests. No worries if not though.

@jonahsnider jonahsnider deleted the feat/float branch December 1, 2021 16:55
@jonahsnider
Copy link
Contributor Author

If you have time and interest, I could use some help with reviewing the open pull requests. No worries if not though.

Sure! Happy to help

@sindresorhus
Copy link
Owner

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Float type support
2 participants
@jonahsnider @sindresorhus