Fix: Simplify handle all types
#414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarab42
commented
Jul 1, 2022
skarab42
changed the title
Simplify handle function typeSimplify handle function type
|
@sindresorhus I think I have found a trick to support any type without testing all cases. The strategy is if the simplified type extends the source type then we return the simplified type otherwise the source. I also added the |
sindresorhus
requested changes
Jul 1, 2022
…into fix-simplify
…into fix-simplify
…into fix-simplify
skarab42
changed the title
Simplify handle function typeSimplify handle all types
skarab42
added a commit
to skarab42/type-fest
that referenced
this pull request
Jul 3, 2022
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #408 (comment)