Skip to content

Add ConditionalSimplify and ConditionalSimplifyDeep types #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 24, 2022

Conversation

skarab42
Copy link
Collaborator

Simplifies a type while including and/or excluding certain types from being simplified.

Related to #436 (comment)

Verified

This commit was signed with the committer’s verified signature.
skarab42 Sébastien Mischler
@skarab42 skarab42 changed the title Add ConditionalSimplify and ConditionalSimplifyDeep Add ConditionalSimplify and ConditionalSimplifyDeep types Aug 24, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
skarab42 Sébastien Mischler

Verified

This commit was signed with the committer’s verified signature.
skarab42 Sébastien Mischler
@skarab42 skarab42 requested a review from sindresorhus August 24, 2022 20:10

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sindresorhus sindresorhus merged commit beaabe1 into sindresorhus:main Aug 24, 2022
@skarab42 skarab42 deleted the feat-conditional-simplify branch August 25, 2022 05:34
@sindresorhus
Copy link
Owner

@skarab42 You have done a lot of great work here lately. Would you be interested in becoming a maintainer? No worries if not :)

@skarab42
Copy link
Collaborator Author

@skarab42 You have done a lot of great work here lately. Would you be interested in becoming a maintainer? No worries if not :)

@sindresorhus Thanks, it's a pleasure and I'm learning a lot :) I would be honoured to become a maintainer 💜

@sindresorhus
Copy link
Owner

Awesome! Welcome :)

@sindresorhus
Copy link
Owner

Even as a maintainer, I still prefer to continue the flow with using pull requests for type additions and larger changes.

@skarab42
Copy link
Collaborator Author

Even as a maintainer, I still prefer to continue the flow with using pull requests for type additions and larger changes.

It's a flow that suits me well :) let's keep it that way 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants