Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Make SetNonNullable 2nd Generic Optional #461

Closed
joealden opened this issue Sep 6, 2022 · 2 comments · Fixed by #482
Closed

Suggestion: Make SetNonNullable 2nd Generic Optional #461

joealden opened this issue Sep 6, 2022 · 2 comments · Fixed by #482

Comments

@joealden
Copy link
Contributor

joealden commented Sep 6, 2022

#431 added the SetNonNullable type, which is very similar to a type we use where I work (see #228 (comment)), but unlike this type, the one in type-fest enforces that the 2nd keys generic is passed. Is there a reason we would be opposed to making the 2nd generic optional (where the default is to make all keys non nullable)?
@joealden
Copy link
Contributor Author

joealden commented Oct 1, 2022

@sindresorhus any thoughts on this? I'm happy to create the PR once I get your approval on the idea.

@sindresorhus
Copy link
Owner

👍 Go for it.

joealden added a commit to joealden/type-fest that referenced this issue Oct 5, 2022
@joealden
Make 2nd SetNonNullable generic optional
93460a0 
sindresorhus#461
@joealden joealden mentioned this issue Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SetNonNullable: Make it possible to apply it to all keys joealden/type-fest
2 participants
@sindresorhus @joealden