Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard npm package.json workspaces field is missing from PackageJson type #510

Closed
electrovir opened this issue Nov 14, 2022 · 1 comment · Fixed by #530
Closed

Standard npm package.json workspaces field is missing from PackageJson type #510

electrovir opened this issue Nov 14, 2022 · 1 comment · Fixed by #530
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@electrovir
Copy link

Workspace setup from Yarn have been covered in #77 but now NPM itself has a workspaces field which is not covered in the PackageJson type: https://docs.npmjs.com/cli/v9/configuring-npm/package-json#workspaces
@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 14, 2022
@bmish bmish mentioned this issue Dec 15, 2022
Merged
@bmish
Copy link
Sponsor Contributor

bmish commented Dec 15, 2022

I opened #530 which should resolve any confusion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweak documentation/comments/organization to mention npm workspaces bmish/type-fest
3 participants
@sindresorhus @bmish @electrovir