Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SetNonNullable Type #515

Merged
merged 6 commits into from Nov 28, 2022
Merged

Conversation

joealden
Copy link
Contributor

Resolves #486.

@sindresorhus
Copy link
Owner

Would you be able to add a type test? So we can ensure it doesn't regress in the future.

@joealden
Copy link
Contributor Author

@sindresorhus I've given this a try in e0f5d9d, but I'm not totally sure how to write a test that tests for this case, as we aren't wanting to test the resulting type, we are instead wanting to test that the type declaration itself (within a function declaration) doesn't throw an error. If the current codes doesn't suffice, could you please take a stab at this?

@sindresorhus sindresorhus merged commit 9bae03b into sindresorhus:main Nov 28, 2022
@sindresorhus
Copy link
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with SetNonNullable in Type Predicate Context
2 participants