jsonify: add jump to definition and any support
#519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinraja
changed the title
any support
MichaelDeBoey
approved these changes
Nov 26, 2022
There was a problem hiding this comment.
Thanks @sachinraja, this is really awesome! 🤩
Once this one's merged, we can start using it in the Remix codebase 😍
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
sindresorhus
requested changes
Nov 27, 2022
MichaelDeBoey
approved these changes
Nov 27, 2022
|
Nice work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are upstreamed from work I did for tRPC and Remix.
For data inferred from
Jsonify, properties do not have jump to definition. This is because key remapping which breaks jump to definition support for TS (see microsoft/TypeScript#47813). I changed it to use a different strategy for filtering that keeps jump to definition.I also added support for the
anytype, previouslyJsonify<any>wasneverand other variations of that were incorrect too.I refactored the implementation because the previous one did not flow well with these changes.
cc @MichaelDeBoey