Update TsConfigJson.CompilerOptions to latest TypeScript #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| Control what method is used to detect module-format JS files. | ||
|
|
||
| Requires TypeScript version 4.7 or later. |
There was a problem hiding this comment.
type-fest requires TS 4.7, so this is moot.
There was a problem hiding this comment.
I don't get it. Why is that?
There was a problem hiding this comment.
Because the only way to get this type is to already be on TS 4.7, so the message of requiring TS 4.7 is not needed.
There was a problem hiding this comment.
Oh. Sorry, I thought you were speaking of the whole PR. 🤪
Anyway, I would respectfully disagree. Users of this type are tsconfig consumers or producers and I think their editor telling them if a property is available in the version of TypeScript they are targeting (vs the one they're using) is a nice thing to have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds: