feat(join): support more cases #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source/join.d.ts
Outdated
| const path: Join<[true, false, true], '.'> = [true, false, true].join('.'); | ||
|
|
||
| // Contains nullish items; result is: 'foo..baz..xyz' | ||
| const path: Join<['foo', undefined, 'baz', null, 'xyz'], '.'> = ['foo', undefined, null, 'baz', undefined, 'xyz'].join('.'); |
There was a problem hiding this comment.
null is in different position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently worked on typing the builtin
Array.prototype.joinmethod in order to handle cases of non-empty arrays (aka tuple with rest param[...T[], T]).Type-fest is my primary goto for complex typing but I saw that the type defined here is missing support for this.
Here I try to provide the fullest signature for
jointhat I could muster.The join type now supports: