Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OverrideProperties doesn't throw an error #608 #609

Merged
merged 2 commits into from Apr 28, 2023
Merged

Fix OverrideProperties doesn't throw an error #608 #609

merged 2 commits into from Apr 28, 2023

Conversation

jinta4020
Copy link
Contributor

@jinta4020 jinta4020 commented Apr 28, 2023 •
edited by sindresorhus

Fixes #608, used Mapping Types instead of Partial.

@sindresorhus
Copy link
Owner

@nidomiro Can you review?

nidomiro
nidomiro approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@nidomiro nidomiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinta4020 thanks for the catch and fix 👍

@sindresorhus I can confirm the bug and that the fix works

@sindresorhus sindresorhus merged commit 44ec7ec into sindresorhus:main Apr 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidomiro nidomiro nidomiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OverrideProperties doesn't throw an error if it has one correct property
3 participants
@jinta4020 @sindresorhus @nidomiro