Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IsLiteral not restrict generics type #684

Merged
merged 2 commits into from
Sep 30, 2023
Merged

fix: IsLiteral not restrict generics type #684

merged 2 commits into from
Sep 30, 2023

Conversation

Emiyaaaaa
Copy link
Collaborator

fix #680

@Emiyaaaaa Emiyaaaaa changed the title fix: #680 IsLiteral not restrict generics type fix: #680 IsLiteral not restrict generics type Sep 8, 2023
@Emiyaaaaa Emiyaaaaa changed the title fix: #680 IsLiteral not restrict generics type fix: IsLiteral not restrict generics type Sep 8, 2023
sindresorhus
sindresorhus requested changes Sep 26, 2023
View reviewed changes
source/is-literal.d.ts Outdated Show resolved Hide resolved
source/is-literal.d.ts Outdated Show resolved Hide resolved
source/is-literal.d.ts Outdated Show resolved Hide resolved
@sindresorhus sindresorhus merged commit 4378507 into sindresorhus:main Sep 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IsLiteral should not require the type to be Primitive but check it internally
2 participants
@Emiyaaaaa @sindresorhus