Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Writable): support array #726

Merged
merged 5 commits into from
Oct 26, 2023
Merged

fix(Writable): support array #726

merged 5 commits into from
Oct 26, 2023
+58 −8

Conversation

Emiyaaaaa
Copy link
Collaborator

Fixed #725

Have a question:

@Emiyaaaaa Emiyaaaaa changed the title Fix writable fix(writable): support array Oct 24, 2023
@Emiyaaaaa Emiyaaaaa changed the title fix(writable): support array fix(Writable): support array Oct 24, 2023
@sindresorhus
Copy link
Owner

Should we suppert Map and Set?

Yes, just make sure you document that this differs from Readonly and link to this TS issue: microsoft/TypeScript#29655

@sindresorhus
Update writable.d.ts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2b88e75
@sindresorhus sindresorhus merged commit b9723d4 into sindresorhus:main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Writable is not suppert array
2 participants
@Emiyaaaaa @sindresorhus