Add ConditionalKeys, ConditionalPick and ConditionalExcept types
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resynth1943
suggested changes
Feb 6, 2020
Nah. |
|
I'll address the requested changes once I have a few moments. |
ifiokjr
force-pushed
the
conditionals
branch
2 times, most recently
from
dadae29
to
7f437b2
Compare
|
I've addressed the requested changes with some minor deviations as explained above. |
|
/cc @sindresorhus LGTM. |
|
Merged in 1... 2... 3... 😛 |
sindresorhus
changed the title
ConditionalKeys, ConditionalPick and ConditionalExcepttypesConditionalKeys, ConditionalPick and ConditionalExcept types
|
Thanks, @ifiokjr 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add types to conditionally pick and exclude properties from any shape based on the provided
Condition.This type comes in handy quite a lot in my library code bases where transforming types or picking properties based on conditions helps dynamically drive automatic inference.
Any suggestions for better names is welcome. Since this code base provides the
Excepttype I've used the nameConditionalExcept. However, it might be more understandable to useConditionalOmit.