Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspaces to PackageJson type #77

Merged
merged 2 commits into from Feb 10, 2020

Conversation

ifiokjr
Copy link
Contributor

@ifiokjr ifiokjr commented Feb 4, 2020

Description

Yarn workspaces are becoming a more prominent feature of the package.json file.

source/package-json.d.ts Outdated Show resolved Hide resolved
source/package-json.d.ts Outdated Show resolved Hide resolved
source/package-json.d.ts Outdated Show resolved Hide resolved
source/package-json.d.ts Outdated Show resolved Hide resolved
source/package-json.d.ts Outdated Show resolved Hide resolved
source/package-json.d.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

It's a welcome addition, but I think the doc comments could be more verbose.

@ifiokjr
Copy link
Contributor Author

ifiokjr commented Feb 6, 2020

I'll address the requested changes soon.

@ifiokjr
Copy link
Contributor Author

ifiokjr commented Feb 9, 2020

I've pushed the requested changes.

@sindresorhus sindresorhus merged commit 836ecb8 into sindresorhus:master Feb 10, 2020
@sindresorhus
Copy link
Owner

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants