MergeDeep
: fixed optional when value type is any
or never
#777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MergeDeep
removes optionals fromany
andnever
fields #775I think @skarab42 uses
EnforceOptional
to restore the '?' by checkundefined
, because he dosen't usedkeyof
in the implementation.Now I used
keyof
to resolve the issue #775 , thusEnforceOptional
is useless, so I seem need remove it, but it will cause some case changed like:But I still think I should remove
EnforceOptional
, what do you think? @sindresorhus