Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type ArraySlice support spread array #828 #832

Merged
merged 1 commit into from Mar 19, 2024
Merged

type ArraySlice support spread array #828 #832

merged 1 commit into from Mar 19, 2024

Conversation

Max10240
Copy link
Contributor

@Max10240 Max10240 commented Mar 14, 2024 •
edited by sindresorhus

Fixes #828

@Max10240
Copy link
Contributor Author

Here we are! so... I checkout a new branch to do this , as @sindresorhus say!
cc @Emiyaaaaa Mind doing CR again here? :)

@sindresorhus
Copy link
Owner

@Emiyaaaaa Does it look good to you? If so, approve the pull request so I know.

@sindresorhus sindresorhus merged commit d2d0d01 into sindresorhus:main Mar 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emiyaaaaa Emiyaaaaa Emiyaaaaa approved these changes

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ArraySlice should support spread array
3 participants
@Max10240 @sindresorhus @Emiyaaaaa