-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][would write PR] use vim.notify for user notifications #473
Comments
I've been meaning to replace the old I think your first suggested course of action is the best one: remove
Are you still interested in writing a PR for this? |
Yes! Thank you for the feedback. I'll open a pr soon based on your plan, or ask followup questions here 👍 |
Great, thank you! I'll go ahead and assign you to the issue. |
fixes sindrets#473 vim.notify allows the user to customize the display of messages
fixes sindrets#473 vim.notify allows the user to customize the display of messages
fixes sindrets#473 vim.notify allows the user to customize the display of messages
I would be interested to write a PR for that, but I'm afraid that you'd reject it, so I would first ask if you'd agree with the approach.
It seems to me that in particular error messages (eg
utils.err()
in the source) are not that emphasized in the GUI. neovim introduced the vim.notify call that can be overridden by users for custom display. For instance the vim.notify plugin offers such an override:https://github.com/rcarriga/nvim-notify
I would like to enable the user to decide between the current display (using
nvim_echo
) or vim.notify, that would allow the user to customize the display.Possible options...
echo_multiln
user_messages_with_notify = false
user_message_displayed
. Although that's a bit redundant, because vim.notify already allows customization but...If you think such a feature has its place in diffview, feel free to let me know which approach you'd rather see, and I can prepare a PR to that effect!
Thank you for an amazing plugin!
The text was updated successfully, but these errors were encountered: