Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] jump to LSP symbol in a diff when possible #487

Open
delabere opened this issue Apr 19, 2024 · 1 comment
Open

[Feature Request] jump to LSP symbol in a diff when possible #487

delabere opened this issue Apr 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@delabere
Copy link

I am using the PR Review guide here
:DiffviewOpen origin/HEAD...HEAD --imply-local

This works really well and I am able to navigate using lsp in the right panel.

What would really enhance this experience would be after going to a definition or a reference of a symbol that is in another file, that it opens up that file as a diff if the file is part of the current diff already.

For example I have a PR with two files, one.go and two.go
A new function is defined in one.go and it is called in two.go.

When I open the diff on file two.go and use my lsp's go to definition on the function call, I would want one.go to open up as if I had just selected it from the file panel, with the rich diff and my cursor on the correct symbol.

Thanks!

@sindrets sindrets added the enhancement New feature or request label May 29, 2024
@sindrets sindrets changed the title [Feature Request] [Feature Request] jump to LSP symbol in a diff when possible May 29, 2024
@dav1d-wright
Copy link

This would be awesome! The one thing I'm missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants