Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator-single-spa): add skipGit #385

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

eckdanny
Copy link

@eckdanny eckdanny commented Aug 12, 2023

Adds skipGit option.

Closes #341.

Was this intentional? The condition is always true so `_installDependencies` is always called.

Verified by running:

`pnpx create-single-spa@4.1.4 --moduleType util-module --skipInstall`

```
? Directory for new project __test
? Which framework do you want to use? none
? Which package manager do you want to use? pnpm
? Will this project use Typescript? No
? Organization name (can use letters, numbers, dash or underscore) org
? Project name (can use letters, numbers, dash or underscore) proj
Initialized empty Git repository in /Users/deck/Workspaces/create-single-spa/__test/.git/

Initialized git repository

   create __test/package.json
   create __test/jest.config.js
   create __test/babel.config.json
   create __test/.eslintrc
   create __test/.prettierignore
   create __test/.gitignore
   create __test/.husky/pre-commit
   create __test/webpack.config.js
   create __test/src/org-proj.js

No change to package.json was detected. No package manager install will be executed.
Skipping install command: pnpm install

I'm all done. Just run pnpm install to install the required dependencies.
```
Adds the `skipGit` option to the SingleSpaGenerator. Refactors (dedupes + hoists) the git initialization routine. Moves git init to the `install` priority queue.
@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2023

🦋 Changeset detected

Latest commit: 321591f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
generator-single-spa Minor
create-single-spa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eckdanny eckdanny marked this pull request as ready for review August 12, 2023 00:25
@eckdanny eckdanny changed the title feat: add skipGit 341 feat(generator-single-spa): add skipGit Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag to disable git init
1 participant