Use --no-detect-globals to bundle and test lolex
#270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our own global check `global || window` only happened to work because browserify wrapped the whole thing with the correct check. With this fix, browserify will not define `global` itself.
mroderick
approved these changes
Oct 10, 2019
benjamingr
approved these changes
Oct 10, 2019
|
Who can cut a release for this? I'm slightly unsure if this should be a patch or a minor 🤔 |
|
Released in |
1 task
|
Hi, pretty sure this is the cause of failures I'm seeing in my build pipeline which uses lolex in puppeteer: Any ideas what I should do about this? Is this something I need to handle or is this a legit bug introduced by this PR? Thanks! |
This was referenced Oct 21, 2019
|
@benadamstyles This is a bug, thanks for reporting! Would it be possible for you to verify that the provided patch actually works? You can copy the bundled source from jsbin here: https://jsbin.com/godesuduxo/edit?html,js,console |
|
Fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Our own global check
global || windowonly happened to work because browserify wrapped the whole thing with the correct check. With this fix, browserify will not defineglobalitself.Note that there is a very ugly hack in the top of the test file now that can / should be removed once nise and sinon received similar updates.
See mantoni/mochify.js#209 and linked issues.