Fix global ReferenceError #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroderick
approved these changes
Oct 21, 2019
|
Here is the reason this wasn't caught by the tests: https://github.com/sinonjs/lolex/blob/44a8d16c94fe0f625e6a82f0d78a77fc588900bd/test/lolex-test.js#L18-L23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fixes #272 which was introduced by #270.
Inspect the result of bundling this branch here: https://jsbin.com/godesuduxo/edit?html,js,console
Background (Problem in detail) - optional
The
globalvariable is not provided by Browerify anymore. I don't fully understand why this isn't caught by test runs in browsers yet. Will need to investigate further.Solution - optional
Use the
_globalvariable which is set towindowin browsers.