Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: expand verify to ensure no async assertions are pending #53

Open
mgred opened this issue Nov 16, 2018 · 4 comments
Open

Feature: expand verify to ensure no async assertions are pending #53

mgred opened this issue Nov 16, 2018 · 4 comments
Assignees

Comments

@mgred
Copy link
Contributor

mgred commented Nov 16, 2018

Extracted form the discussion of #47.

#47 (comment)

* If #45 lands, then expand `verify` to ensure all promises from `resolves` and `rejects` are resolved or rejected

The following example will pass, because we don't let the test runner handle the returned promise.

describe("some test", function() {
    it("should resolve", function() {
        referee.assert.resolves(Promise.resolve(42), 43);
    }):
});

This issue is an approach to verify if all async assertions have been properly resolved.

@mroderick, @mantoni

@mroderick
Copy link
Member

Go for it!

@mgred mgred self-assigned this Nov 17, 2018
@rpgeeganage
Copy link

@mgred,
if you are not looking into this, I can give it a try.

@mroderick
Copy link
Member

@mgred,
if you are not looking into this, I can give it a try.

I don't think they'll be too upset if your work overlaps ... and after six months, I think it's fair to take it up 👍

@rpgeeganage
Copy link

@mroderick ,
Thanks. I will look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants