Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepEqual returns true for different promise instances #216

Closed
mantoni opened this issue Mar 5, 2021 · 1 comment
Closed

deepEqual returns true for different promise instances #216

mantoni opened this issue Mar 5, 2021 · 1 comment

Comments

@mantoni
Copy link
Member

mantoni commented Mar 5, 2021

  • library version : 5.3.1 (current)
  • Environment : node 14

What did you expect to happen?

samsam.deepEqual returns false for different promise objects.

What actually happens

samsam.deepEqual returns true for different promise objects.

How to reproduce

const samsam = require('@sinonjs/samsam');

const p1 = Promise.resolve('a');
const p2 = Promise.resolve('b');
console.log(samsam.deepEqual(p1, p2)); // should return false

Reported in Sinon: sinonjs/sinon#2345

@fatso83
Copy link
Contributor

fatso83 commented May 24, 2021

verified fixed by #217

@fatso83 fatso83 closed this as completed May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants