Fix failing reset() on sandbox with unused fake server #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearphage
requested changes
May 26, 2017
test/sandbox-test.js
Outdated
| @@ -56,6 +56,18 @@ describe("sinonSandbox", function () { | |||
| assert.same(sandbox.assert, sinonAssert); | |||
| }); | |||
|
|
|||
| it("can be reset without failing when pre-configured to use a fake server", function () { | |||
| var sandbox = sinonSandbox.create({useFakeServer: true}); | |||
| sandbox.reset(); | |||
There was a problem hiding this comment.
There are no assertions in either test. How did this fail before your changes?
There was a problem hiding this comment.
ah, good catch. I'll add some kind of refutation along with throws (don't remember the exact api).
failing test
1) sinonSandbox can be reset without failing when configured to use a fake server:
TypeError: Cannot set property 'length' of undefined
at Object.resetBehavior (lib/sinon/util/fake_server.js:279:51)
at Object.reset (lib/sinon/util/fake_server.js:274:14)
at lib/sinon/collection.js:26:21
at Array.forEach (native)
at each (lib/sinon/collection.js:25:19)
at Object.reset (lib/sinon/collection.js:41:9)
at Context.<anonymous> (test/sandbox-test.js:68:17)
There was a problem hiding this comment.
OK, pushed a fix. Output before fix:
1306 passing (846ms)
4 pending
2 failing
1) sinonSandbox can be reset without failing when pre-configured to use a fake server:
AssertionError: [refute.exception] Expected not to throw but threw TypeError (Cannot set property 'length' of undefined)
at referee.fail (node_modules/referee/lib/referee.js:193:25)
at Object.fail (node_modules/referee/lib/referee.js:90:21)
at assertion (node_modules/referee/lib/referee.js:98:21)
at Function.referee.(anonymous function).(anonymous function) [as exception] (node_modules/referee/lib/referee.js:118:23)
at Context.<anonymous> (test/sandbox-test.js:61:16)
2) sinonSandbox can be reset without failing when configured to use a fake server:
AssertionError: [refute.exception] Expected not to throw but threw TypeError (Cannot set property 'length' of undefined)
at referee.fail (node_modules/referee/lib/referee.js:193:25)
at Object.fail (node_modules/referee/lib/referee.js:90:21)
at assertion (node_modules/referee/lib/referee.js:98:21)
at Function.referee.(anonymous function).(anonymous function) [as exception] (node_modules/referee/lib/referee.js:118:23)
at Context.<anonymous> (test/sandbox-test.js:69:16)
fatso83
force-pushed
the
failing-sandbox-reset
branch
from
874b9c1
to
0bf0a79
Compare
fearphage
approved these changes
May 26, 2017
|
This has become part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
sandbox.reset()fails when the sandbox has been configured to use a fake server and the server has not been utilized. This is the standard config forsinon-testand was revealed to crash in sinonjs/sinon-test#57Background (Problem in detail) - optional
will crash immediately today due to the fields not being initalized.
Solution - optional
Initializes the fields at creation time.
How to verify - mandatory
npm installgit reset --hard HEAD~1 && npm test #pre-fix the tests failgit merge && npm test #after fix the tests pass