Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate spy.reset() in favor of the more explicit spy.resetHistory() #1446

Closed
fearphage opened this issue Jun 2, 2017 · 4 comments
Closed

Comments

@fearphage
Copy link
Member

Spy currently has a reset method which functions as resetHistory. It would make the intention and functionality of the method more clear if it were named appropriately.

@fearphage
Copy link
Member Author

The idea for this ticket started in #1424.

@GCHQDeveloper500
Copy link
Contributor

Picked this one up as it was marked as "Help Wanted" - hope that's okay.

@stale
Copy link

stale bot commented Feb 6, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 6, 2018
@mroderick
Copy link
Member

This was done with #1630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants