Default server type when using sandbox.useFakeServer() doesn't match documentation

[lsglick]

• Sinon version : master
• Environment :
• Example URL :
• Other libraries you are using:

What did you expect to happen?
Creating a fake server with sandbox.useFakeServer() should create a fakeServer instance. (According to docs here: http://sinonjs.org/releases/v3.2.0/sandbox/)

What actually happens
It creates a fakeServerWithClock instance.

How to reproduce

var sandbox = sinon.sandbox.create();
sandbox.useFakeServer();
// Verify sandbox.server is a fakeServerWithClock

Workaround is to manually set sandbox.serverPrototype before calling .useFakeServer() since unlike creating server from the sandbox config, there is no way to specify the server prototype when calling the method version of useFakeServer.

This appears to simply be due to setting the wrong prototype here:

sinon/lib/sinon/sandbox.js

Line 58 in d9cae73

serverPrototype: fakeServerWithClock,

So the default || fakeServer is never reached:

sinon/lib/sinon/sandbox.js

Line 61 in d9cae73

var proto = this.serverPrototype || fakeServer;

.

[fatso83]

This is basically expanding on #1429. Feel free to have a go at fixing the docs :-)
edit: I was wrong. Read your issue too hastily. I see that you report an actual bug now, as well as reporting on the docs.

Regarding your workaround, it seems overly complicated, why can't you just send in a normal configuration object? This should accomplish the same:

sinon.sandbox.create({
    useFakeTimers: false,
    useFakeServer: true
})

[mantoni]

Just ran into this issue as well. I can confirm that this installs a fake server without clock:

sandbox = sinon.createSandbox({
  useFakeServer: true
});

while the following seems to work at first, but installs the fake timers when the first XHR request is made:

sandbox = sinon.createSandbox();
sandbox.useFakeServer();

[mantoni]

Actually it's worse. First config version also fails. I'll send a patch in a minute.

[mroderick]

This has been fixed in sinon@4.1.5

[mroderick]

I made a mistake when building sinon@4.1.5, so it has been deprecated.
All hail sinon@4.1.6