Document that it is allowed to assert on dedicated spy calls.

[Flarna]

Purpose (TL;DR) - mandatory

Document that some asserts can be done on a SpyCall not only on a Spy. Fixes #1471

I updated only master of the doc. Once I'm told that wording is ok and change is accepted I can update also older releases.

How to verify - mandatory

N/A - just doc update

Checklist for author

• npm run lint passes
• References to standard library functions are cached.

[mroderick]

Thank you for your pull request @Flarna

Reviewing this pull request allowed me to discover that we are missing tests for some of the assertions. Only in one place do we verify that an assertion also works with a spyCall as the first argument.

Would you be up for expanding your pull request?

• Add missing documentation for all the assertions that supports both spy and spyCall
• Add missing tests for all the assertions that supports both spy and spyCall
• Change documentation examples to use spyOrSpyCall as the name of the first argument
  sinon.assert.calledWith(spyOrSpyCall, arg1, arg2, ...);

[Flarna]

sure, will do that - hopefully soon.

Add missing documentation for all the assertions that supports both spy and spyCall

I thought I found all of them - but looking again I think that I forgot calledWithNew. Do you know if there are others which should support spy and spyCall?

[Flarna]

@mroderick Updated docs and added tests. I tried to act like a a roman in rome in the tests; hope it fits.

Still pending is the merge into older docs.

[mroderick]

Looks good to me 👍

Do go ahead and fold the documentation updates into the older docs.

[Flarna]

@mroderick older docs are updated now

[mroderick]

This has been published to npm as sinon@4.4.1