Calling sandbox.replace not cleaning up if called more than once

[mantoni]

When calling sandbox.replace twice for the same object + property, the original state can not be restored.

Reproduce:

sinon.replace(console, "log", sinon.fake());
sinon.replace(console, "log", sinon.fake());
sinon.restore();
console.log; // Still a proxy object

There are two different ways to solve this:

• We throw on the second attempt to use sinon.replace, like sinon.stub(obj, prop) fails if it's already a fake
• We allow multiple calls to use sinon.replace, but restore to the original state properly

I'd try to come up with an implementation if we know which direction to take. I'm not really decided here.

[mroderick]

Trying to replace a fake with a fake seems like something that should warrant an investigation by the programmer. I would prefer to have tests fail, rather than sinon glossing over my mistakes. Throwing get's my vote.

[mantoni]

I agree. I was trying to think of other scenarios, like using replace to set a number or so, but in any case, doing that multiple times in a single test seems dodgy.

I’m also leaning more towards throwing now.

[mroderick]

This was fixed with sinon@5.0.5