sinon.fake() argument passes wrong type

[Shagamii]

• Sinon version : 5.0.3
• Environment : node v8.9.3

What did you expect to happen?
Expect sinon.fake() argument to be a function or no argument.

What actually happens
sinon.fake() passes all type, because func are typos instead of f

How to reproduce
Before:

function fake(f) {
    if (typeof func !== "undefined" && typeof func !== "function") {
        throw new TypeError("Expected func argument to be a Function");
    }

    return wrapFunc(f);
}

After:

function fake(f) {
    if (typeof f !== "undefined" && typeof f !== "function") {
        throw new TypeError("Expected f argument to be a Function");
    }

    return wrapFunc(f);
}

[mroderick]

Thank you for the error report and the PR 👍

Based on your PR, I created a pull request that also has a test for the failure, so we will catch it if there are regressions.

[mroderick]

This has been fixed with sinon@5.0.4

[Shagamii]

Thanks!
Sorry to miss some🙏