Upgrade to samsam 3

[mantoni]

Purpose (TL;DR) - mandatory

WORK IN PROGRESS! DO NOT MERGE

This PR integrates the changes from sinonjs/samsam#49 with Sinon. Since samsam 3 is not yet release, the build is failing.

See intructions below on how to verify locally.

Changes

• lib/sinon/util/core/deep-equal.js is replaced with samsam.deepEqual.
• lib/match.js now simply exposes samsam.createMatcher.
• Removed obsolete files:
  • lib/sinon/util/core/every.js
  • lib/sinon/util/core/iterable-to-string.js
  • lib/sinon/util/core/typeOf.js
• Removed obsolete dependencies:
  • lodash.get
  • type-detect
• Parameter ordering of samsam.deepEqual has changed from (expected, actual) to (actual, expected)

How to verify - mandatory

1. Check out this branch
2. npm install
3. npm test

Checklist for author

• npm run lint passes
• References to standard library functions are cached.

[mroderick]

I love PRs like these!

[coveralls]

Pull Request Test Coverage Report for Build 2766

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 22 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.7%) to 94.517%

---

Files with Coverage Reduction	New Missed Lines	%
sinon/mock.js	1	96.64%
sinon/spy.js	21	90.05%

Totals
Change from base Build 2758:	-0.7%
Covered Lines:	1663
Relevant Lines:	1729

---

💛 - Coveralls

[mantoni]

Samsam 3 was released and this is passing all tests in all environments. Ready for review.

It was required to update formatio and nise to avoid having two versions of samsam in the "production" dependency tree.

We could also wait for the next major version of referee to only have samsam 3 in the development dependency tree. However, all tests work fine with the current version too.

[mroderick]

I have verified this locally

[fearphage]

lib/sinon/match.js seems like a candidate for removal.

[mantoni]

@fearphage Thank you for reviewing. You're absolutely right. I kept the tests and match.js file initially to show that these changes do not break any tests. Now that the change is complete and all tests pass, I feel confident removing them.