Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mock.withArgs using matchers #1961

Merged
merged 1 commit into from Dec 12, 2018
Merged

Fix mock.withArgs using matchers #1961

merged 1 commit into from Dec 12, 2018

Conversation

mantoni
Copy link
Member

@mantoni mantoni commented Dec 12, 2018

Purpose (TL;DR) - mandatory

Fixes #1960

Background (Problem in detail) - optional

The deepEqual semantics in @sinonjs/samsam have changed in v3 to be (actual, expected) instead of (expected, actual). There was a call left unchanged since no test case existed for this case.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm t

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2778

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.522%

Totals Coverage Status
Change from base Build 2775: 0.0%
Covered Lines: 1663
Relevant Lines: 1729

💛 - Coveralls

@mantoni mantoni merged commit 011018c into master Dec 12, 2018
@mantoni mantoni deleted the fix-mock-withargs-match branch December 12, 2018 08:13
@dueyfx
Copy link

dueyfx commented Dec 13, 2018

@mantoni Thanks for the quick fix!

franck-romano pushed a commit to franck-romano/sinon that referenced this pull request Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants