Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Currently
sinon.stub(function () {})
throwsTypeError: Attempted to wrap undefined property undefined as function
. Sinon should either throw a meaningful error explaining why afunction
is not a valid argument, or treat functions like any other object. I can't think of a reason why we shouldn't support this.Fixes #1967
How to verify - mandatory
npm install
npm t
Checklist for author
npm run lint
passes