Document spying on accessors

[salomvary]

Closes #1606

Purpose (TL;DR) - mandatory

Adds documentation for an undocumented feature.

How to verify - mandatory

1. Check out this branch
2. Open docs/_releases/latest/spies.md

Checklist for author

• npm run lint passes
• References to standard library functions are cached.

[coveralls]

Pull Request Test Coverage Report for Build 2790

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 94.526%

---

Totals
Change from base Build 2788:	0.0%
Covered Lines:	1664
Relevant Lines:	1730

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 2817

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 15 unchanged lines in 4 files lost coverage.
• Overall coverage decreased (-0.4%) to 94.15%

---

Files with Coverage Reduction	New Missed Lines	%
sinon/mock.js	1	96.62%
sinon/spy.js	2	89.98%
sinon/stub.js	3	91.02%
sinon/util/core/wrap-method.js	9	79.41%

Totals
Change from base Build 2788:	-0.4%
Covered Lines:	1650
Relevant Lines:	1718

---

💛 - Coveralls

[mroderick]

Documentation updates are very valuable to open source projects ⭐️

The documentation for Sinon is a bit special, so you'll have to also put the changes into all the previous releases for which this applies.

It's sort of hinted in https://github.com/sinonjs/sinon/blob/master/docs/CONTRIBUTING.md#example-documenting-a-fixed-bug, just not in a very obvious way.

Documentation is an area I'd like to significantly improve in 2019.

The feature was added with #692, which became part of sinon@1.14.0, so you'll have to add the changes to all the releases in docs/_releases.

If you can manage to do the changes before March 9th, then we can merge it before it becomes four years after the feature was added 😊

Thank you for contributing to documentation of Sinon 💯

[salomvary]

@mroderick Challenge accepted! :)

[salomvary]

For the record, the trick was:

git diff HEAD~ HEAD > doc.diff
find . -path '*docs/_releases/v*' -name spies.md | xargs -I {} patch {} doc.diff

[mantoni]

Awesome! This was pending for a long time. Thank you very much ❤️

[fatso83]

I am working on trying to make docs fixes a bit easier "for the rest of us", @mroderick. I'll have something soon.

[mroderick]

I am working on trying to make docs fixes a bit easier "for the rest of us", @mroderick. I'll have something soon.

Let's talk about that during our call tomorrow ... one of the topics I'd like to talk about is documentation :)

[mroderick]

Thank you :)