don't call extends.nonEnum in spy.resetHistory

[Flarna]

Purpose (TL;DR) - mandatory

Fixes #1983 by not calling extends.nonEnum() in spy.resetHistory()

It seems that extends.nonEnum() is significant slower then just setting properties. By ensuring that the properties on the proxy exist as non enumerable during creation it's not needed to use extends.nonEnum() during updating them.

Refs: #1975

How to verify - mandatory

1. Check out this branch
2. npm install
3. npm test

Not sure what to write here as there is no functional change...

Checklist for author

• npm run lint passes
• References to standard library functions are cached.

[mantoni]

Oh, nice! Is there already a test verifying that resetHistory doesn't make the properties enumerable again? If not, it'd be great to have one.

[Flarna]

Well, seems in #1975 no test was added to verify that spy/subs/.. do not expose any enumerable properties.

I will add some test for this.

[Flarna]

@ehmicky I found that an enumerable property named fakes is added if I call spy.withArgs(1). is this one of the properties you kept visible because it broke the tests?

[ehmicky]

@Flarna I unfortunately don't remember. However I do remember that I kept few properties visible because it broke the tests and/or it was introducing too many changes in a codebase I am not familiar with.

[Flarna]

Added tests.
Additionally fixed mirroring of properties on spied function and make property fakes non enumerable.
If I should split this into two PRs let me know.

I found that stubs still have their properties enumerable. It would be quite easy to change this but I don't think I should add this here.

[mantoni]

Thanks for putting this together. There is no need to split this into separate PRs.

However, I'd like those tests to be more focused on the enumerable porperties. We're already testing the spy functionality extensively. I can help and change them myself, if you give me permission to push to this PR.

[Flarna]

@mantoni You should have permissions to add commits (according to the checkbox Allow edits from maintainers.).

The main idea here was to call serveral spy APIs to ensure that they don't add any enumerable properties. Maybe just remove the asserts there and keep only that ones checking the enumerable properties?

[mantoni]

Yeah, that should be good enough I think 👍

[mantoni]

Thank you 👍

[mroderick]

This has been published as sinon@7.2.5.

[3z3qu13l]

Could you update Changelog and create new release based on 7.2.5 plz ?
Thanks

[mantoni]

Sure thing. Will do right now.

[mantoni]

@mroderick Do you have pending commits for master to push maybe?

[mantoni]

@3z3qu13l Change log and documentation page have been updated.