Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create COMPATIBILITY.md #2051

Merged
merged 2 commits into from Jun 24, 2019
Merged

Create COMPATIBILITY.md #2051

merged 2 commits into from Jun 24, 2019

Conversation

mroderick
Copy link
Member

This PR moves the description of compatibility goals into its own file, making it easy to elaborate on and link to.

@mroderick mroderick requested a review from fatso83 June 24, 2019 10:30
Copy link
Member

@mantoni mantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2888

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.186%

Totals Coverage Status
Change from base Build 2884: 0.0%
Covered Lines: 1660
Relevant Lines: 1729

💛 - Coveralls

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fatso83 fatso83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestion

Co-Authored-By: Carl-Erik Kopseng <carlerik@gmail.com>
@mroderick mroderick merged commit 013b9e1 into master Jun 24, 2019
@mroderick mroderick deleted the move-compatibility-to-readme branch June 24, 2019 16:07
franck-romano pushed a commit to franck-romano/sinon that referenced this pull request Oct 1, 2019
* Create COMPATIBILITY.md
* Update README.md

Co-Authored-By: Carl-Erik Kopseng <carlerik@gmail.com>
@sinonjs sinonjs locked and limited conversation to collaborators Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants