Fix Typo in migration 6 and updated migration docs for migration from… #2074
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2954
💛 - Coveralls |
|
@fatso83 Any review regarding this? |
fatso83
requested changes
Aug 26, 2019
docs/guides/migrating-to-7.0.md
Outdated
| breadcrumb: migrating to 7.0 | ||
| --- | ||
|
|
||
| For upgrading to new Sinon 7 there are no known major breaking Changes except **negative ticks** are not allowed in `Sinon@7` due to update to lolex 3. So you cannot use negative values in sinon.useFakeTimers().tick(); |
There was a problem hiding this comment.
@fatso83 I have changed the text. Thanks for reviewing
fatso83
reviewed
Aug 26, 2019
docs/guides/migrating-to-7.0.md
Outdated
| @@ -4,7 +4,7 @@ title: Migrating to v7.0 - Sinon.JS | |||
| breadcrumb: migrating to 7.0 | |||
| --- | |||
|
|
|||
| For upgrading to new Sinon 7 there are no known major breaking Changes except **negative ticks** are not allowed in `Sinon@7` due to update to lolex 3. So you cannot use negative values in sinon.useFakeTimers().tick(); | |||
| For upgrading to new Sinon 7 there is no known major breaking Change except **negative ticks** are not allowed in `Sinon@7` due to update to lolex 3. So you cannot use negative values in sinon.useFakeTimers().tick(); | |||
There was a problem hiding this comment.
I didn't object to the plural, but the letter casing 😄
There was a problem hiding this comment.
My Bad I could not understand your fat Arrow Function. 😆.
fatso83
approved these changes
Aug 26, 2019
|
Thank you for your pull request 🚀 |
franck-romano
pushed a commit
to franck-romano/sinon
that referenced
this pull request
Oct 1, 2019
sinonjs#2074) * Fix Typo in migration 6 and updated migration docs for migration from 6 to 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - Created Migration guide for migration from version 6 to version 7
How to verify - mandatory
npm installChecklist for author
npm run lintpasses