Force upgrade @sinonjs/commons

[mroderick]

Fixes #2180

Background

I guess @sinonjs/commons should have had a major version bump somewhere along the way, when the API changed.

Solution

• Force @sinonjs/commons to latest

How to verify - mandatory

1. Observe tests pass

[mantoni]

No, it was correct to release the global feature as a minor. But we need to force upgrade features that we depend on, because if someone installed sinon v7, they get the transitive dependencies locked in the package-lock.json. I suppose in this case, upgrading sinon to v8 did not upgrade commons, unless it's a fresh install.

[mantoni]

Here is how this happened:

This is the commit that introduced the new commons feature in Sinon and it should have had the commons upgrade: f34a13e

In the same commit, I upgraded commons in the sinon tree implicitly because I had to reinstall all dependencies with rm -rf node_modules package-lock.json: f34a13e#diff-32607347f8126e6534ebc7ebaec4853dR188

This was necessary, because I ran into this npm issue: https://npm.community/t/cannot-read-property-match-of-undefined/203

Otherwise tests would have failed and it would have been obvious that commons needed an upgrade.