Support negative indices in getCall #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows getting calls indexed from the end of the array e.g. -1 gets the last call, -2 gets the penultimate call etc.
fatso83
reviewed
Jan 15, 2020
|
This has been published to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows getting calls indexed from the end of the array
e.g. -1 gets the last call, -2 gets the penultimate call etc.
Purpose (TL;DR)
Implements the proposal in #2196
Allows the user to get the -nth call when the total number of calls is arbitrary, without having to wrap around getCalls() function.
In an ideal world, the full set of calls should be known and this function would not be necessary, but for some use cases this can be useful (see #2196 for my use case). I understand this is a bit of a niche case so don't mind if you choose to close instead of merge!
How to verify
npm installnpm test