The upgrade of the supports-color package as part of v11 is now breaking tests over non-ES2018 browsers.

[diegocr]

Describe the bug
Summary says it all, i.e.

25 05 2021 12:31:33.199:INFO [Firefox 60.0 (Linux x86_64)]: Connected on socket 3eTU1cCfGrgUvf7TxzsB with id 79759455
Firefox 60.0 (Linux x86_64) ERROR
  SyntaxError: invalid regexp group
  at node_modules/sinon/pkg/sinon.js:16263:17

Reported to them at chalk/supports-color#111 (comment)

[fatso83]

Hi, thanks for reporting!

If you need support for older browser, use Sinon 9. Starting with Sinon 10 we only support evergreen browsers + Safari: https://github.com/sinonjs/sinon/blob/master/COMPATIBILITY.md

There is not much new in the newer releases 😃

[diegocr]

Hmm, okay. FYI Sinon 10 does work fine in Firefox 60, what we're dealing with here is the use of RegExp's capture groups that is only supported in ES2018+ and therefore you may consider updating that compatibility page to remove the mention of ES2017 😃

[fatso83]

Hmm ... true, that is a bit confusing. The source version of ES is more about what kind of syntax contributors can write, but totally agree it's unfortunate. The supported runtimes still hold, of course, but maybe we should write ES2018. @mroderick ?

[diegocr]

TBH, i don't think it is worth bumping the ES version requirement of Sinon just because that single package is using something it does not really requires (as i told them in their repo), this is just causing troubles unnecessarily, IMHO.

[fatso83]

No matter what we do about this issue, just be prepared that your Firefox 60 version might still break at any later update: the only runtimes we claim to support are the two latest browser versions of evergreens and officially supported LTS versions of Node.

[diegocr]

Thanks for sorting this out.

We're using Firefox 60 ESR to run our Karma tests since that is the lowest Firefox version we do require to support at my company's website. So yeah we're prepared for it, but when there is a good reason - we would also like to use latest versions of all packages as the way to get security advisories sorted.

[mroderick]

Thank you for reporting this issue 👍