Un-pin @sinonjs/fake-timers #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit upgrading from v9 to v10 appears to have accidentally dropped the caret from the version range, pinning it to a single version: aa493da Un-pinning the version will allow sinon and its consumers to automatically pick up new in-range versions of @sinonjs/fake-timers as they're released in the future.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2495 +/- ##
=======================================
Coverage 95.95% 95.95%
=======================================
Files 38 38
Lines 1878 1878
=======================================
Hits 1802 1802
Misses 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
fatso83
approved these changes
Mar 12, 2023
|
Ooh, thanks for picking that up! |
fatso83
pushed a commit
that referenced
this pull request
Mar 12, 2023
The commit upgrading from v9 to v10 appears to have accidentally dropped the caret from the version range, pinning it to a single version: aa493da Un-pinning the version will allow sinon and its consumers to automatically pick up new in-range versions of @sinonjs/fake-timers as they're released in the future.
|
published as sinon 15.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR)
The commit upgrading from v9 to v10 appears to have accidentally dropped the caret from the version range, pinning it to a single version: aa493da
Un-pinning the version will allow sinon and its consumers to automatically pick up new in-range versions of @sinonjs/fake-timers as they're released in the future.
How to verify
npm install@sinonjs/fake-timersshould still be installedChecklist for author
npm run lintpasses