Use no-op for every function when restoring instances #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatso83
added a commit
that referenced
this pull request
Mar 12, 2023
* issue-2477 Use no-op for every function when restoring instances * Change wording to not depend on mutator type in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fixes the issue brought up in #2477 by adding default no-op implementations of all the functions present on the prototype of a stub instance object. This avoids issues that might arise if code traverses an object that already has been restored by having a default set of no-op function to fiddle with, instead of accidentally invoking stuff on the prototype which might or might not depend on the constructor being run to work correctly.
How to verify - mandatory
npm testand check against the example in #2477Checklist for author
npm run lintpasses