Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METHOD_NOW_FINAL false positive on private … to protected final … change #295

Open
chrisvest opened this issue Aug 18, 2021 · 1 comment

Comments

@chrisvest
Copy link

I had the following method:

    private boolean useIpv6(InetAddress address) {
        …
    }

and changed it to

    protected final boolean useIpv6(InetAddress address) {
        …
    }

which produced the following complaint from japicmp:

There is at least one incompatibility: io.netty.channel.unix.Socket.useIpv6(java.net.InetAddress):METHOD_NOW_FINAL

I worked around it by introducing a static method in netty/netty@2b70575 but I think that should not be necessary.

This is with using japicmp maven plug-in version 0.15.3.

@normanmaurer
Copy link

This might be a duplicate of #265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants