Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on user's clock times #340

Open
miriam-rittenberg opened this issue Dec 3, 2019 · 2 comments
Open

Don't rely on user's clock times #340

miriam-rittenberg opened this issue Dec 3, 2019 · 2 comments
Labels
bug Something isn't working e2 high effort p2 high priority

Comments

@miriam-rittenberg
Copy link
Contributor

If you add a new class and then reload, the class sometimes disappears. This also sometimes happens if you log out and log back in. If you add two classes sometimes one of them stays and the other one disappears. This is currently in master. The branch latest-release is currently being deployed.

@miriam-rittenberg miriam-rittenberg added bug Something isn't working p1 very high priority labels Dec 3, 2019
@miriam-rittenberg
Copy link
Contributor Author

This was caused by my computer clock being two minutes slow, not by the new code. We should still add a warning or change something so your clock being wrong doesn't make the classes fail to save.

@miriam-rittenberg miriam-rittenberg added p2 high priority and removed p1 very high priority labels Dec 12, 2019
@miriam-rittenberg miriam-rittenberg changed the title The localstorage merge caused master to sometimes not save classes. The localstorage merge caused master to sometimes not save classes. EDIT: Caused by my clock being wrong, not local storage Dec 12, 2019
@georgiashay georgiashay changed the title The localstorage merge caused master to sometimes not save classes. EDIT: Caused by my clock being wrong, not local storage Don't rely on user's clock times Dec 13, 2019
@georgiashay
Copy link
Collaborator

We should change how time works to not rely on user's clocks which may be incorrect

@georgiashay georgiashay added the e2 high effort label Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working e2 high effort p2 high priority
Projects
None yet
Development

No branches or pull requests

2 participants