Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Null pointer exception if using MdnsResolve #1116

Open
helu-milestone opened this issue May 2, 2024 · 1 comment
Open

Possible Null pointer exception if using MdnsResolve #1116

helu-milestone opened this issue May 2, 2024 · 1 comment

Comments

@helu-milestone
Copy link

helu-milestone commented May 2, 2024

In RtpIceChannel.cs line 2645 returns null in case the MdnsResolve fails to resolve the mDNS address. I think null should be changed into an Empty.Array() to avoid null pointer exception in line 1376.

I would like to make a pull request with this small fix, but I have no branch. How do I contribute to the project?

@helu-milestone
Copy link
Author

For anyone else new to OpenSource you can make a fork of the repository. Create a fix in your own repository and after that github will show that you are ahead of SipSorcery repostory and you can make a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant