Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate time table #289

Open
1 task
zven opened this issue Mar 8, 2023 · 3 comments
Open
1 task

Deactivate time table #289

zven opened this issue Mar 8, 2023 · 3 comments
Assignees

Comments

@zven
Copy link
Contributor

zven commented Mar 8, 2023

At the moment, there is a simple timetable view implemented where you can pick and chose the different POIs.

We are still in the process of discussing if we want to keep it in or not: A two week long study might simply be too short to create a meaningful timetable?

Todos:

  • add / reuse feature flag to enable de-activation of time table feature
@zven zven created this issue from a note in Prototype v0 (Next) Mar 8, 2023
@zven zven changed the title Adjust or kick deactivate table Adjust or kick deactivate time table Mar 8, 2023
@zven zven changed the title Adjust or kick deactivate time table Adjust or deactivate time table Mar 8, 2023
@zven zven changed the title Adjust or deactivate time table Deactivate time table Mar 28, 2023
@zven
Copy link
Contributor Author

zven commented Mar 28, 2023

We leave the timetable out.

@felixerdy felixerdy self-assigned this Apr 17, 2023
@felixerdy felixerdy moved this from Next to In progress in Prototype v0 Apr 17, 2023
@felixerdy
Copy link
Collaborator

After taking a look into the feature-flag.fixtures.ts file there are already 2 flags related to the timetable:

  • isTrajectoryExplorationTabEnabled which shows / hides the exploration tab where the timetable is shown
  • isTimetableComputationEnabled which enables / disables the timetable computation and shows / hides the "Predict next visit" Button in the map view

Thus I'd suggest to disable those feature flags in #271 in order to deactivate the timetable

@felixerdy felixerdy moved this from In progress to Ready for review in Prototype v0 Apr 17, 2023
@jbraese
Copy link
Collaborator

jbraese commented Apr 25, 2023

Makes perfect sense to me.

@jbraese jbraese moved this from Ready for review to Done in Prototype v0 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants