Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some problems with the i18n text #65

Open
wordpure opened this issue May 31, 2023 · 2 comments
Open

Some problems with the i18n text #65

wordpure opened this issue May 31, 2023 · 2 comments
Assignees

Comments

@wordpure
Copy link
Contributor

Problem

  1. i18n field of some text changed

    图片

    图片

  2. Some texts do not have i18n counterparts

    Images

    图片

    图片

    图片

    图片

    图片

    图片

    图片

  3. Text that is not in i18n but will automatically change according to the user's language

    图片

    图片

  4. Some i18n don't seem to show up in the interface

    图片

    图片

URL

irrelevant

Version

0.8

Browser

Firefox 114

OS

Windows 11

Device

PC

@sixcious sixcious self-assigned this Jun 1, 2023
@sixcious
Copy link
Owner

sixcious commented Jul 1, 2023

Hi again wordpure, thank you for opening this issue (and sorry for the delay)!

Yes, so I think you might have been using your own GitHub translation with the Web Store build, but the GitHub build (April 2023) is about a month behind the Web Store build (May 2023). I added and changed some things, so it won't sync up perfectly. You brought up some other interesting things I didn't notice though. For example, I never i18n'd the Keyboard Shortcuts so they aren't translatable; I'll do that for the next release. (I'm not sure what's wrong with Point 3 though; isn't that a good thing?)

Unfortunately, my local copy of Infy isn't quite ready to be pushed up to GitHub. I'm not sure when I'll be working on Infy again, but we can keep this issue open for now.

Thank you again for your translation work!💜

@wordpure
Copy link
Contributor Author

wordpure commented Jul 2, 2023

Yes, so I think you might have been using your own GitHub translation with the Web Store build, but the GitHub build (April 2023) is about a month behind the Web Store build (May 2023).

Thank you for your reminder.

As you said, the translation issue was due to differences in the extension store and Github versions. I deleted the extension downloaded by Firefox Addons (if not deleted, just disable the extension store version, and then temporarily install the Github version, it seems that the new i18n text of the Github version will not work due to the same version number), after adding the Github extension, Most of the translated text displayed normally.

I'm not sure what's wrong with Point 3 though; isn't that a good thing?

It's a good thing indeed, I'm just curious as to why it happened. But now it seems that the browser should automatically add the prompt text for the number type input with max, min and step set.

my local copy of Infy isn't quite ready to be pushed up to GitHub. I'm not sure when I'll be working on Infy again, but we can keep this issue open for now.

Thank you for your great work and I look forward to seeing Infy get better and more perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants