Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add empty space for fixing out-bounds elements #83

Open
1 task done
ilias-7565 opened this issue Feb 15, 2024 · 8 comments
Open
1 task done

Ability to add empty space for fixing out-bounds elements #83

ilias-7565 opened this issue Feb 15, 2024 · 8 comments
Assignees
Labels

Comments

@ilias-7565
Copy link

Feature Request

Some websites don't fully work on small screenes. As an example, in landscape mode on a phone, use search on https://developer.mozilla.org/en-US/docs/Web , you won't be able to get all it's results.

Adherence

  • I have read the Sticky and my feature request is an actual feature that can be added into the app and is not related to making it work with a specific website
@sixcious sixcious self-assigned this Feb 16, 2024
@sixcious
Copy link
Owner

Hi ilias-7565, thanks for opening this issue!

I don't quite understand your feature request; could you please elaborate and provide a screenshot of the problem, as well as the Saved URL object you are using and your device specs to help show what you mean? MDN is an AJAX site and I have no issues with getting all the search results to display properly using the Click Action and AJAX Append Mode on a mobile device in landscape mode.

For context, here's what I'm seeing on a very small Pixel phone:
Screenshot

Also, if you need to add some empty space or alter the CSS in any way to make it work with your device, you could use a Userstyle or Userscript Manager. (I would recommend trying Stylus first.)

I hope this helps. 💜

@ilias-7565
Copy link
Author

ilias-7565 commented Feb 16, 2024

Don't press Enter, try using the pop-up list on small screen. This is just an example, such was an actual issue on some sites which i came across before.

@sixcious
Copy link
Owner

sixcious commented Feb 17, 2024

Hi, I don't have an Enter key to press as I'm testing this all on a mobile device. Could you please provide a screenshot showing the problem, the Saved URL settings you are using, and your mobile device's specifications (resolution, OS, and browser) so I can try and reproduce this?

@ilias-7565
Copy link
Author

ilias-7565 commented Feb 18, 2024

Use device's Back button to hide the keyboard to see the issue.

Screenshot_20240218-122204_Firefox

@sixcious
Copy link
Owner

Hi again ilias-7565,

OK, it took me a really long time to figure out what you were actually referring to. I don't think this is related to Infy Scroll. The grey "pop-up" search results is MDN's own web design, and the same thing happens without using Infy Scroll. Please contact Mozilla and open an issue to let them know so they can fix it. Or you can use a Userstyle Manager like Stylus to add the CSS to fix it. Unfortunately, this feature really falls outside the scope of functionality of what Infy Scroll does.

Sorry, I know that's not what you were hoping to hear, but I really hope that helps. 💜

@ilias-7565
Copy link
Author

Ik that its probably not what you meant when have chosen the name for addon, but you could add the infy scroll margins capability too :) . Its up to you though, you can close this Issue if you want, this functionality isn't required. Adding Stylus only for this, also on mobile, is a bit too much.

@sixcious
Copy link
Owner

I totally get where you're coming from! 💜 It seems like it's a simple margin issue, but that div.search-results popup on MDN's site is positioned absolutely, and since each site is different, it's really going to require some custom CSS or JS to fix. Google has become a lot more strict with MV3 and I'm worried they might consider something like that to be remote code execution. If I were to add that in via the new chrome.userScripts API, it could creep on violating their Single-use policy because Infy is not really a userstyle or userscript manager like Stylus and ViolentMonkey are.

I plan on reevaluating custom CSS/JS in the future to see if it can be allowed. I honestly think the best option is to open an issue with the website/MDN because it's their own code and you shouldn't have to put up with using a 3rd party app to fix it 💜

@ilias-7565
Copy link
Author

ilias-7565 commented Feb 27, 2024

I didn't know about the google thing. I totally agree that they should fix it, but that has high chance of happening on other sites. Hoping and waiting for devs of each site to fix/{not introduce} it isn't very logical.

Ty for attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants