Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with SSR example #1505

Open
priand opened this issue Aug 16, 2018 · 3 comments
Open

Issue with SSR example #1505

priand opened this issue Aug 16, 2018 · 3 comments

Comments

@priand
Copy link

priand commented Aug 16, 2018

Bug report

  • Skate version: 5.2.3 (npm info skatejs version)
  • Affected browsers (and versions): n/a

Current behaviour

npm start on the SSR example (skatejs/packages/ssr/example) generates an error with undom. Looks like undom/register does not exists in undom 0.3.3

ssr-wc@1.0.0 start /Users/priand/CommerceCloudDev/source/StencilJS/skatejs/packages/ssr/example
node .

module.js:549
throw err;
^

Error: Cannot find module 'undom/register'
at Function.Module._resolveFilename (module.js:547:15)
at Function.Module._load (module.js:474:25)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object. (/Users/priand/CommerceCloudDev/source/StencilJS/skatejs/packages/ssr/register/index.js:14:1)
at Module._compile (module.js:652:30)
at loader (/Users/priand/CommerceCloudDev/source/StencilJS/skatejs/packages/ssr/example/node_modules/babel-register/lib/node.js:144:5)
at Object.require.extensions.(anonymous function) [as .js] (/Users/priand/CommerceCloudDev/source/StencilJS/skatejs/packages/ssr/example/node_modules/babel-register/lib/node.js:154:7)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! ssr-wc@1.0.0 start: node .
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the ssr-wc@1.0.0 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Expected behaviour

Should run :-)

@treshugart
Copy link
Member

Hmm, interesting. I'm looking at Undom 0.3.3 here and it looks like it's there.

screen shot 2018-08-30 at 12 05 00 am

Did you ensure you ran bolt after cloning the repo? You also have to npm i in the examples directory.

@priand
Copy link
Author

priand commented Sep 2, 2018

Yeah, it the module is there but there is no 'register' function.
I initially did not run bolt as I did not know that the example required it. I now did it but got a different error, see bellow ;-(

I'd like to start from scratch using a fresh clone. What commands need to be run in order to make the ssr example run?

ssr-wc@1.0.0 start /Users/priand/webcomponents/skatejs/packages/ssr/example
node .

/Users/priand/webcomponents/skatejs/packages/ssr/example/index.js:13
server.connection({
^

TypeError: server.connection is not a function
at Object. (/Users/priand/webcomponents/skatejs/packages/ssr/example/index.js:13:8)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)

@treshugart
Copy link
Member

I probably should just start from scratch with the example, it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants