Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why Minify_CSS::minify and CssMin::minify #56

Open
adoerler opened this issue Dec 2, 2019 · 0 comments
Open

Why Minify_CSS::minify and CssMin::minify #56

adoerler opened this issue Dec 2, 2019 · 0 comments

Comments

@adoerler
Copy link

adoerler commented Dec 2, 2019

Hi,

if cssFileCompile is enabled, each file configured in the asset gets minified (using Minify_CSS::minify) at:
https://github.com/skeeks-semenov/yii2-assets-auto-compress/blob/master/src/AssetsAutoCompressComponent.php#L534

If cssFileCompress is enabled, it will get minified a few lines later again (using CssMin::minify):
https://github.com/skeeks-semenov/yii2-assets-auto-compress/blob/master/src/AssetsAutoCompressComponent.php#L568

I think complie should only concatenate the asset files into a single CSS file and it should compress this single CSS file only once and only if cssFileCompress is enabled.

What do you think?
Andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant